Get type from auto with index operator#4826
Merged
firewave merged 9 commits intocppcheck-opensource:mainfrom Feb 28, 2023
Merged
Get type from auto with index operator#4826firewave merged 9 commits intocppcheck-opensource:mainfrom
firewave merged 9 commits intocppcheck-opensource:mainfrom
Conversation
pfultz2
reviewed
Feb 25, 2023
| while (Token::Match(varTok, "%name% ::")) | ||
| varTok = varTok->tokAt(2); | ||
| while (Token::simpleMatch(varTok, "[")) | ||
| varTok = varTok->astOperand1(); |
Contributor
There was a problem hiding this comment.
The typeDecl of an index expression shouldn't be the decl of the container.
|
|
||
| check("void f(std::vector<std::unordered_map<int, std::unordered_set<int>>>& v, int i, int j) {\n" | ||
| " auto& s = v[i][j];\n" | ||
| " s.insert(0);\n" |
Contributor
There was a problem hiding this comment.
There should be test that the valueType of s is unordered_set.
Collaborator
Author
There was a problem hiding this comment.
Turns out the ValueType was correct all along, but we don't use that when looking up member functions.
I have added a test where there is no ambiguity between containers.
pfultz2
approved these changes
Feb 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.